Messages in this thread | | | From | Omer Shpigelman <> | Subject | RE: [PATCH v2 1/2] habanalabs: support kernel memory mapping | Date | Thu, 24 Oct 2019 08:07:01 +0000 |
| |
On Thu, Oct 24, 2019 at 04:29 AM Christoph Hellwig <hch@infradead.org> wrote: > On Wed, Oct 23, 2019 at 01:39:41PM +0000, Omer Shpigelman wrote: > > I'm not sure I understand. Can you please pin point the problematic line? > > Every line you touch addr field basically. If you have a kernel address please > store it in an actual C pointer type, not in a u64 to ensure that the compiler > can do proper type checking.
I see your point. I'll separate the code so the kernel address path will use a pointer type rather than u64.
| |