Messages in this thread | | | Date | Thu, 24 Oct 2019 16:59:01 -0700 (PDT) | From | Paul Walmsley <> | Subject | Re: [PATCH v3 1/8] riscv: add prototypes for assembly language functions from entry.S |
| |
On Fri, 18 Oct 2019, Christoph Hellwig wrote:
> On Fri, Oct 18, 2019 at 01:08:34AM -0700, Paul Walmsley wrote: > > Add prototypes for assembly language functions defined in entry.S, > > and include these prototypes into C source files that call those > > functions. > > > > This patch resolves the following warnings from sparse: > > > > arch/riscv/kernel/signal.c:32:53: warning: incorrect type in initializer (different address spaces) > > I don't see how adding prototypes will fix an address space warning.
You're right - that was a cut-and-paste error on my part.
[ ... ] > All these are not defined in entry.S, but called from entry.S.
Indeed. After reviewing this patch closely, I've just dropped it, and used __visible for just about everything. All that is reflected in the v4 series.
Thanks for the review.
- Paul
| |