Messages in this thread | | | From | Logan Gunthorpe <> | Date | Thu, 24 Oct 2019 16:40:58 -0600 | Subject | Re: [PATCH 3/7] nvmet: Introduce common execute function for get_log_page and identify |
| |
On 2019-10-24 4:01 p.m., Keith Busch wrote: > On Thu, Oct 24, 2019 at 11:18:20AM -0600, Logan Gunthorpe wrote: >> On 2019-10-23 7:17 p.m., Christoph Hellwig wrote: >>> >>> First signoff needs to be the From line picked up by git. I don't really >>> care if you keep my attribution or not, but if you do it needs From >>> line for me as the first theing in the mail body, and if not it >>> should drop by signoff and just say based on a patch from me. >>> >>> Otherwise the series looks fine. >> >> Ok, understood. Do you want me to fix this up in a v2? Or can you fix it >> up when you pick up the patches? > > I'll adjust with the commit. Just let me know which way you'd like to go, > whether attribute author to Christoph or use the "Based-on-a-patch-by:" > option.
Attribute the author to Christoph. It was all pretty much verbatim from the draft patch he sent anyway. I just split it up and tested it.
Thanks,
Logan
| |