Messages in this thread Patch in this message | | | Date | Wed, 23 Oct 2019 10:06:40 +0200 | From | Daniel Wagner <> | Subject | Re: [PATCH] net: usb: lan78xx: Use phy_mac_interrupt() for interrupt handling |
| |
Sebastian suggested to try this here:
--- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1264,8 +1264,11 @@ static void lan78xx_status(struct lan78xx_net *dev, struct urb *urb) netif_dbg(dev, link, dev->net, "PHY INTR: 0x%08x\n", intdata); lan78xx_defer_kevent(dev, EVENT_LINK_RESET); - if (dev->domain_data.phyirq > 0) + if (dev->domain_data.phyirq > 0) { + local_irq_disable(); generic_handle_irq(dev->domain_data.phyirq); + local_irq_enable(); + } } else netdev_warn(dev->net, "unexpected interrupt: 0x%08x\n", intdata); While this gets rid of the warning, the networking interface is not really stable:
[ 43.999628] nfs: server 192.168.19.2 not responding, still trying [ 43.999633] nfs: server 192.168.19.2 not responding, still trying [ 43.999649] nfs: server 192.168.19.2 not responding, still trying [ 43.999674] nfs: server 192.168.19.2 not responding, still trying [ 43.999678] nfs: server 192.168.19.2 not responding, still trying [ 44.006712] nfs: server 192.168.19.2 OK [ 44.018443] nfs: server 192.168.19.2 OK [ 44.024765] nfs: server 192.168.19.2 OK [ 44.025361] nfs: server 192.168.19.2 OK [ 44.025420] nfs: server 192.168.19.2 OK [ 256.991659] nfs: server 192.168.19.2 not responding, still trying [ 256.991664] nfs: server 192.168.19.2 not responding, still trying [ 256.991669] nfs: server 192.168.19.2 not responding, still trying [ 256.991685] nfs: server 192.168.19.2 not responding, still trying [ 256.991713] nfs: server 192.168.19.2 not responding, still trying [ 256.998797] nfs: server 192.168.19.2 OK [ 256.999745] nfs: server 192.168.19.2 OK [ 256.999828] nfs: server 192.168.19.2 OK [ 257.000438] nfs: server 192.168.19.2 OK [ 257.004784] nfs: server 192.168.19.2 OK
Eventually, the rootfs can be loaded and the system boots. Though the system is not really usable because it often stalls:
root@debian:~# apt update Ign:1 http://deb.debian.org/debian stretch InRelease Hit:2 http://deb.debian.org/debian stretch Release Reading package lists... 0%
I don't see this with the irqdomain code reverted.
| |