lkml.org 
[lkml]   [2019]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2] clocksource/drivers: Fix memory leak in ttc_setup_clockevent
    From
    Date
    > In the implementation of ttc_setup_clockevent() release the allocated
    > memory for ttcce if clk_notifier_register() fails.

    I got other wording preferences. Thus I imagine that such a change
    description can still be improved another bit.
    Would you like to express the addition of a jump target (according to
    the Linux coding style) for the completion of desired exception handling
    in a different way?



    > +++ b/drivers/clocksource/timer-cadence-ttc.c

    > @@ -453,15 +451,18 @@ static int __init ttc_setup_clockevent(struct clk *clk,

    > +release_ttcce:
    > +
    > + kfree(ttcce);


    I would prefer that a blank line will not be added directly after such a label.

    Regards,
    Markus

    \
     
     \ /
      Last update: 2019-10-23 10:01    [W:3.051 / U:0.592 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site