Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 22 Oct 2019 20:03:00 +0200 | Subject | Re: [PATCH v2 10/11] gpio: pca953x: Convert to use bitmap API |
| |
Hi Andy,
On Tue, Oct 22, 2019 at 7:29 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Instead of customized approach convert the driver to use bitmap API. > > Depends-on: 6e9c6674d1bf ("gpio: pca953x: utilize the for_each_set_clump8 macro") > Cc: William Breathitt Gray <vilhelm.gray@gmail.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > Cc: Marek Vasut <marek.vasut+renesas@gmail.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> --- a/drivers/gpio/gpio-pca953x.c > +++ b/drivers/gpio/gpio-pca953x.c > @@ -9,8 +9,7 @@ > */ > > #include <linux/acpi.h> > -#include <linux/bits.h> > -#include <linux/bitops.h> > +#include <linux/bitmap.h> > #include <linux/gpio/driver.h> > #include <linux/gpio/consumer.h> > #include <linux/i2c.h> > @@ -116,6 +115,7 @@ MODULE_DEVICE_TABLE(acpi, pca953x_acpi_ids); > > #define MAX_BANK 5 > #define BANK_SZ 8 > +#define MAX_LINE (MAX_BANK * BANK_SZ)
Given (almost) everything is now bitmap (i.e. long [])-based, you might as well increase MAX_BANK to a multiple of 4 or 8, e.g. 8.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |