Messages in this thread | | | Subject | Re: [PATCH v4 1/2] dt-bindings: edac: al-mc-edac: Amazon's Annapurna Labs Memory Controller EDAC | From | "Shenhar, Talel" <> | Date | Tue, 22 Oct 2019 11:14:05 +0300 |
| |
Thanks Rob,
On 10/11/2019 4:29 PM, Rob Herring wrote: > On Thu, Oct 10, 2019 at 02:54:13PM +0300, Talel Shenhar wrote: >> Document Amazon's Annapurna Labs Memory Controller EDAC SoC binding. >> >> Signed-off-by: Talel Shenhar <talel@amazon.com> >> --- >> .../bindings/edac/amazon,al-mc-edac.yaml | 50 ++++++++++++++++++++++ >> 1 file changed, 50 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml >> >> diff --git a/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml b/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml >> new file mode 100644 >> index 00000000..f66b094 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml >> @@ -0,0 +1,50 @@ >> +# SPDX-License-Identifier: GPL-2.0 > Forgot to mention, please make new bindings (GPL-2.0-only OR BSD-2-Clause). ack, shall be part of v5 > + interrupts: >> + maxItems: 2 >> + items: >> + - description: uncorrectable error interrupt >> + - description: correctable error interrupt >> + >> + interrupt-names: >> + maxItems: 2 >> + items: >> + - const: ue >> + - const: ce > Now the example fails to build: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.example.dt.yaml: > edac@f0080000: interrupt-names: ['ue'] is too short > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.example.dt.yaml: > edac@f0080000: interrupts: [[20, 4]] is too short > > You either need to always have the CE irq or add 'minItems: 1' to both.
Indeed adding the minItems to 1 solves this.
However, shouldn't it really be 0? interrupts are not mandatory?
What is the way to capture this in the new binding?
> +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + edac@f0080000 { > + compatible = "amazon,al-mc-edac"; > + reg = <0x0 0xf0080000 0x0 0x00010000>; > + interrupt-parent = <&amazon_al_system_fabric>; > + interrupt-names = "ue"; > + interrupts = <20 IRQ_TYPE_LEVEL_HIGH>; > + }; > -- > 2.7.4 >
| |