Messages in this thread | | | Date | Sat, 19 Oct 2019 11:39:00 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH] mtd: rawnand: brcmnand: Fix sparse warning in has_flash_dma() |
| |
Hi Florian,
Florian Fainelli <f.fainelli@gmail.com> wrote on Fri, 18 Oct 2019 16:38:44 -0700:
> Sparse rightfully complained about has_flash_dma(): > +drivers/mtd/nand/brcmnand/brcmnand.c:951:40: warning: Using plain integer as NULL pointer [sparse]
I don't get why would sparse complain about this... Anyway I prefer the !!(<pointer>) alternative if you don't mind. Otherwise the "!= NULL" comparison feels wrong.
> > Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > index 15ef30b368a5..73f7a0945399 100644 > --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > @@ -909,7 +909,7 @@ static inline void brcmnand_set_wp(struct brcmnand_controller *ctrl, bool en) > > static inline bool has_flash_dma(struct brcmnand_controller *ctrl) > { > - return ctrl->flash_dma_base; > + return ctrl->flash_dma_base != NULL; > } > > static inline void disable_ctrl_irqs(struct brcmnand_controller *ctrl)
Thanks, Miquèl
| |