Messages in this thread | | | Subject | Re: [PATCH v12 07/22] riscv: mm: Add p?d_leaf() definitions | From | Steven Price <> | Date | Fri, 18 Oct 2019 17:20:30 +0100 |
| |
On 18/10/2019 16:57, Christoph Hellwig wrote: >> + return pud_present(pud) >> + && (pud_val(pud) & (_PAGE_READ | _PAGE_WRITE | _PAGE_EXEC)); >> +} > > The operators always need to go before the line break, not after it > per linux coding style. There are a few more spots like this, so please > audit the whole series for it.
Fair enough. In this case I was just copying the example in pte_huge() that already existed - but you're right this isn't the kernel coding style.
Thanks,
Steve
| |