Messages in this thread | | | Subject | Re: [PATCH v1 4/4] net: dsa: add support for Atheros AR9331 build-in switch | From | Florian Fainelli <> | Date | Thu, 17 Oct 2019 11:35:48 -0700 |
| |
On 10/13/2019 11:15 PM, Oleksij Rempel wrote: > Provide basic support for Atheros AR9331 build-in switch. So far it > works as port multiplexer without any hardware offloading support.
I glanced through the functional parts of the code, and it looks pretty straight forward, since there is no offloading done so far, do you plan on adding bridge offload eventually if nothing more?
When you submit v2, I would suggest splitting the tagger code from the switch driver code, just to make them easier to review.
Thanks! -- Florian
| |