Messages in this thread | | | Date | Thu, 17 Oct 2019 18:30:44 +0530 | From | Manivannan Sadhasivam <> | Subject | Re: [PATCH -next 26/30] pinctrl: bm1880: use devm_platform_ioremap_resource() to simplify code |
| |
On Thu, Oct 17, 2019 at 08:26:36PM +0800, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks, Mani
> --- > drivers/pinctrl/pinctrl-bm1880.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c > index 63b130c..f7dff4f 100644 > --- a/drivers/pinctrl/pinctrl-bm1880.c > +++ b/drivers/pinctrl/pinctrl-bm1880.c > @@ -1308,15 +1308,13 @@ static struct pinctrl_desc bm1880_desc = { > static int bm1880_pinctrl_probe(struct platform_device *pdev) > > { > - struct resource *res; > struct bm1880_pinctrl *pctrl; > > pctrl = devm_kzalloc(&pdev->dev, sizeof(*pctrl), GFP_KERNEL); > if (!pctrl) > return -ENOMEM; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - pctrl->base = devm_ioremap_resource(&pdev->dev, res); > + pctrl->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(pctrl->base)) > return PTR_ERR(pctrl->base); > > -- > 2.7.4 > >
| |