lkml.org 
[lkml]   [2019]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Cluster-devel] [PATCH] gfs2: make gfs2_fs_parameters static
From
Date
On 17/10/2019 12:02, Ben Dooks (Codethink) wrote:
> The gfs2_fs_parameters is not used outside the unit
> it is declared in, so make it static.
>
> Fixes the following sparse warning:
>
> fs/gfs2/ops_fstype.c:1331:39: warning: symbol 'gfs2_fs_parameters' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Bob Peterson <rpeterso@redhat.com>
> Cc: Andreas Gruenbacher <agruenba@redhat.com>
> Cc: cluster-devel@redhat.com
> Cc: linux-kernel@vger.kernel.org
> ---
> fs/gfs2/ops_fstype.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> index 681b44682b0d..ebdef1c5f580 100644
> --- a/fs/gfs2/ops_fstype.c
> +++ b/fs/gfs2/ops_fstype.c
> @@ -1328,7 +1328,7 @@ static const struct fs_parameter_enum gfs2_param_enums[] = {
> {}
> };
>
> -const struct fs_parameter_description gfs2_fs_parameters = {
> +static const struct fs_parameter_description gfs2_fs_parameters = {
> .name = "gfs2",
> .specs = gfs2_param_specs,
> .enums = gfs2_param_enums,
>

Looks good to me.

Thanks,
Andy

\
 
 \ /
  Last update: 2019-10-17 13:42    [W:0.100 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site