lkml.org 
[lkml]   [2019]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 6/7] Powerpc/Watchpoint: Add dar outside test in perf-hwbreak.c selftest
    Date
    So far we used to ignore exception if dar points outside of user
    specified range. But now we are ignoring it only if actual load/
    store range does not overlap with user specified range. Include
    selftests for the same:

    # ./tools/testing/selftests/powerpc/ptrace/perf-hwbreak
    ...
    TESTED: No overlap
    TESTED: Partial overlap
    TESTED: Partial overlap
    TESTED: No overlap
    TESTED: Full overlap
    success: perf_hwbreak

    Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
    ---
    .../selftests/powerpc/ptrace/perf-hwbreak.c | 119 +++++++++++++++++-
    1 file changed, 118 insertions(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/powerpc/ptrace/perf-hwbreak.c b/tools/testing/selftests/powerpc/ptrace/perf-hwbreak.c
    index 200337daec42..c1f324afdbf3 100644
    --- a/tools/testing/selftests/powerpc/ptrace/perf-hwbreak.c
    +++ b/tools/testing/selftests/powerpc/ptrace/perf-hwbreak.c
    @@ -148,6 +148,121 @@ static int runtestsingle(int readwriteflag, int exclude_user, int arraytest)
    return 0;
    }

    +static int runtest_dar_outside(void)
    +{
    + void *target;
    + volatile __u16 temp16;
    + volatile __u64 temp64;
    + struct perf_event_attr attr;
    + int break_fd;
    + unsigned long long breaks;
    + int fail = 0;
    + size_t res;
    +
    + target = malloc(8);
    + if (!target) {
    + perror("malloc failed");
    + exit(EXIT_FAILURE);
    + }
    +
    + /* setup counters */
    + memset(&attr, 0, sizeof(attr));
    + attr.disabled = 1;
    + attr.type = PERF_TYPE_BREAKPOINT;
    + attr.exclude_kernel = 1;
    + attr.exclude_hv = 1;
    + attr.exclude_guest = 1;
    + attr.bp_type = HW_BREAKPOINT_RW;
    + /* watch middle half of target array */
    + attr.bp_addr = (__u64)(target + 2);
    + attr.bp_len = 4;
    + break_fd = sys_perf_event_open(&attr, 0, -1, -1, 0);
    + if (break_fd < 0) {
    + free(target);
    + perror("sys_perf_event_open");
    + exit(EXIT_FAILURE);
    + }
    +
    + /* Shouldn't hit. */
    + ioctl(break_fd, PERF_EVENT_IOC_RESET);
    + ioctl(break_fd, PERF_EVENT_IOC_ENABLE);
    + temp16 = *((__u16 *)target);
    + *((__u16 *)target) = temp16;
    + ioctl(break_fd, PERF_EVENT_IOC_DISABLE);
    + res = read(break_fd, &breaks, sizeof(unsigned long long));
    + assert(res == sizeof(unsigned long long));
    + if (breaks == 0) {
    + printf("TESTED: No overlap\n");
    + } else {
    + printf("FAILED: No overlap: %lld != 0\n", breaks);
    + fail = 1;
    + }
    +
    + /* Hit */
    + ioctl(break_fd, PERF_EVENT_IOC_RESET);
    + ioctl(break_fd, PERF_EVENT_IOC_ENABLE);
    + temp16 = *((__u16 *)(target + 1));
    + *((__u16 *)(target + 1)) = temp16;
    + ioctl(break_fd, PERF_EVENT_IOC_DISABLE);
    + res = read(break_fd, &breaks, sizeof(unsigned long long));
    + assert(res == sizeof(unsigned long long));
    + if (breaks == 2) {
    + printf("TESTED: Partial overlap\n");
    + } else {
    + printf("FAILED: Partial overlap: %lld != 2\n", breaks);
    + fail = 1;
    + }
    +
    + /* Hit */
    + ioctl(break_fd, PERF_EVENT_IOC_RESET);
    + ioctl(break_fd, PERF_EVENT_IOC_ENABLE);
    + temp16 = *((__u16 *)(target + 5));
    + *((__u16 *)(target + 5)) = temp16;
    + ioctl(break_fd, PERF_EVENT_IOC_DISABLE);
    + res = read(break_fd, &breaks, sizeof(unsigned long long));
    + assert(res == sizeof(unsigned long long));
    + if (breaks == 2) {
    + printf("TESTED: Partial overlap\n");
    + } else {
    + printf("FAILED: Partial overlap: %lld != 2\n", breaks);
    + fail = 1;
    + }
    +
    + /* Shouldn't Hit */
    + ioctl(break_fd, PERF_EVENT_IOC_RESET);
    + ioctl(break_fd, PERF_EVENT_IOC_ENABLE);
    + temp16 = *((__u16 *)(target + 6));
    + *((__u16 *)(target + 6)) = temp16;
    + ioctl(break_fd, PERF_EVENT_IOC_DISABLE);
    + res = read(break_fd, &breaks, sizeof(unsigned long long));
    + assert(res == sizeof(unsigned long long));
    + if (breaks == 0) {
    + printf("TESTED: No overlap\n");
    + } else {
    + printf("FAILED: No overlap: %lld != 0\n", breaks);
    + fail = 1;
    + }
    +
    + /* Hit */
    + ioctl(break_fd, PERF_EVENT_IOC_RESET);
    + ioctl(break_fd, PERF_EVENT_IOC_ENABLE);
    + temp64 = *((__u64 *)target);
    + *((__u64 *)target) = temp64;
    + ioctl(break_fd, PERF_EVENT_IOC_DISABLE);
    + res = read(break_fd, &breaks, sizeof(unsigned long long));
    + assert(res == sizeof(unsigned long long));
    + if (breaks == 2) {
    + printf("TESTED: Full overlap\n");
    + } else {
    + printf("FAILED: Full overlap: %lld != 2\n", breaks);
    + fail = 1;
    + }
    +
    + free(target);
    + close(break_fd);
    + return fail;
    +}
    +
    static int runtest(void)
    {
    int rwflag;
    @@ -172,7 +287,9 @@ static int runtest(void)
    return ret;
    }
    }
    - return 0;
    +
    + ret = runtest_dar_outside();
    + return ret;
    }


    --
    2.21.0
    \
     
     \ /
      Last update: 2019-10-17 11:33    [W:2.635 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site