Messages in this thread | | | Subject | Re: [PATCH RESEND v2 1/4] dt-bindings: power: add Amlogic secure power domains bindings | From | Jianxin Pan <> | Date | Wed, 16 Oct 2019 19:26:49 +0800 |
| |
Hi Rob,
On 2019/10/15 1:39, Rob Herring wrote: > On Thu, Oct 10, 2019 at 04:21:15AM -0400, Jianxin Pan wrote: >> Add the bindings for the Amlogic Secure power domains, controlling the >> secure power domains. >> >> The bindings targets the Amlogic A1 and C1 compatible SoCs, in which the >> power domain registers are in secure world. >> >> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> >> --- >> .../bindings/power/amlogic,meson-sec-pwrc.yaml | 42 ++++++++++++++++++++++ >> include/dt-bindings/power/meson-a1-power.h | 32 +++++++++++++++++ >> 2 files changed, 74 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >> + >> + secure-monitor: >> + description: phandle to the secure-monitor node >> + $ref: /schemas/types.yaml#/definitions/phandle > > Why not just a child node of this node? > Thanks for the review.
I followed the style of the previous series of meson:
46 efuse: efuse { 47 compatible = "amlogic,meson-gxbb-efuse"; 48 clocks = <&clkc CLKID_EFUSE>; 49 #address-cells = <1>; 50 #size-cells = <1>; 51 read-only; 52 secure-monitor = <&sm>; 53 };
> Rob > > . >
| |