lkml.org 
[lkml]   [2019]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500
    From
    Date
    On Fri, 2019-10-11 at 14:30 -0700, Vijay Khemka wrote:
    > HW checksum generation is not working for AST2500, specially with
    > IPV6
    > over NCSI. All TCP packets with IPv6 get dropped. By disabling this
    > it works perfectly fine with IPV6. As it works for IPV4 so enabled
    > hw checksum back for IPV4.
    >
    > Verified with IPV6 enabled and can do ssh.

    So while this probably works, I don't think this is the right
    approach, at least according to the comments in skbuff.h

    The driver should have handled unsupported csum via SW fallback
    already in ftgmac100_prep_tx_csum()

    Can you check why this didn't work for you ?

    Cheers,
    Ben.

    > Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
    > ---
    > Changes since v1:
    > Enabled IPV4 hw checksum generation as it works for IPV4.
    >
    > drivers/net/ethernet/faraday/ftgmac100.c | 13 ++++++++++++-
    > 1 file changed, 12 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
    > b/drivers/net/ethernet/faraday/ftgmac100.c
    > index 030fed65393e..0255a28d2958 100644
    > --- a/drivers/net/ethernet/faraday/ftgmac100.c
    > +++ b/drivers/net/ethernet/faraday/ftgmac100.c
    > @@ -1842,8 +1842,19 @@ static int ftgmac100_probe(struct
    > platform_device *pdev)
    > /* AST2400 doesn't have working HW checksum generation */
    > if (np && (of_device_is_compatible(np, "aspeed,ast2400-mac")))
    > netdev->hw_features &= ~NETIF_F_HW_CSUM;
    > +
    > + /* AST2500 doesn't have working HW checksum generation for IPV6
    > + * but it works for IPV4, so disabling hw checksum and enabling
    > + * it for only IPV4.
    > + */
    > + if (np && (of_device_is_compatible(np, "aspeed,ast2500-mac")))
    > {
    > + netdev->hw_features &= ~NETIF_F_HW_CSUM;
    > + netdev->hw_features |= NETIF_F_IP_CSUM;
    > + }
    > +
    > if (np && of_get_property(np, "no-hw-checksum", NULL))
    > - netdev->hw_features &= ~(NETIF_F_HW_CSUM |
    > NETIF_F_RXCSUM);
    > + netdev->hw_features &= ~(NETIF_F_HW_CSUM |
    > NETIF_F_RXCSUM
    > + | NETIF_F_IP_CSUM);
    > netdev->features |= netdev->hw_features;
    >
    > /* register network device */

    \
     
     \ /
      Last update: 2019-10-17 03:30    [W:6.146 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site