Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 16 Oct 2019 19:31:33 +0300 | Subject | Re: [PATCH v5] printf: add support for printing symbolic error names |
| |
On Wed, Oct 16, 2019 at 5:52 PM Petr Mladek <pmladek@suse.com> wrote: > > On Wed 2019-10-16 16:49:41, Andy Shevchenko wrote: > > On Tue, Oct 15, 2019 at 10:07 PM Rasmus Villemoes > > <linux@rasmusvillemoes.dk> wrote: > > > > > +const char *errname(int err) > > > +{ > > > + const char *name = __errname(err > 0 ? err : -err); > > > > Looks like mine comment left unseen. > > What about to simple use abs(err) here? > > Andy, would you want to ack the patch with this change? > I could do it when pushing the patch.
Looks good to me. Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Otherwise, it looks ready to go. > > Thanks everybody involved for the patience.
-- With Best Regards, Andy Shevchenko
| |