Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 15 Oct 2019 11:21:44 +0200 | Subject | Re: [PATCH] serial: core: Use cons->index for preferred console registration |
| |
On Tue, Oct 15, 2019 at 11:19 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Mon, Sep 2, 2019 at 4:29 PM Michal Simek <michal.simek@xilinx.com> wrote: > > The reason for this patch is xilinx_uartps driver which create one dynamic > > instance per IP with unique major and minor combinations. drv->nr is in > > this case all the time setup to 1. That means that uport->line is all the > > time setup to 0 and drv->tty_driver->name_base is doing shift in name to > > for example ttyPS3. > > > > register_console() is looping over console_cmdline array and looking for > > proper name/index combination which is in our case ttyPS/3. > > That's why every instance of driver needs to be registered with proper > > combination of name/number (ttyPS/3). Using uport->line is doing > > registration with ttyPS/0 which is wrong that's why proper console index > > should be used which is in cons->index field. > > > > Also it is visible that recording console should be done based on > > information about console not about the port but in most cases numbers are > > the same and xilinx_uartps is only one exception now. > > > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > > This is now commit 91daae03188e0dd1 ("serial: core: Use cons->index > for preferred console registration") in tty-next. > > This has been bisected to break the serial console on (at least) > r8a7791/koelsch and r8a7795/h3-salvator-xs. > > The line "printk: console [ttySC0] enabled" is no longer printed.
s/is no longer printed/no longer appears in the kernel log/, of course.
> The system continues booting without any serial console output, and the > login prompt never appears on the serial console.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |