Messages in this thread | | | Date | Fri, 11 Oct 2019 20:32:38 +0300 | From | Wambui Karuga <> | Subject | Re: [Outreachy kernel] Re: [PATCH v3 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals |
| |
On Fri, Oct 11, 2019 at 02:08:47PM +0200, Greg KH wrote: > On Fri, Oct 11, 2019 at 02:07:17PM +0200, Greg KH wrote: > > On Fri, Oct 11, 2019 at 01:54:04PM +0300, Dan Carpenter wrote: > > > On Thu, Oct 10, 2019 at 04:15:29PM +0300, Wambui Karuga wrote: > > > > psetauthparm = rtw_zmalloc(sizeof(struct setauth_parm)); > > > > - if (psetauthparm == NULL) { > > > > - kfree(pcmd); > > > > + if (!psetauthparm) { > > > > + kfree((unsigned char *)pcmd); > > > > > > This new cast is unnecessary and weird. > > > > Ah, I missed that, good catch. I'll go drop this patch now. > > And that caused the second patch to get dropped as well. I'll just drop > them all, can you redo the whole series please? > > thanks, > > greg k-h > The cast seems to have been removed earlier by Nachammai Karuppiah and added to staging-testing, but I added it back when I cherry-picked my changes to the new file.
Sorry. :( I can remove the cast and send a new series. Thanks.
wambui karuga
| |