lkml.org 
[lkml]   [2019]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 3/4] drm/komeda: Add drm_ctm_to_coeffs()
    Date
    On Friday, 11 October 2019 06:45:42 BST james qian wang (Arm Technology China) wrote:
    > This function is for converting drm_color_ctm matrix to komeda hardware
    > required required Q2.12 2's complement CSC matrix.
    >
    > v2:
    > Move the fixpoint conversion function s31_32_to_q2_12() to drm core
    > as a shared helper.
    >
    > Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
    > ---
    > .../gpu/drm/arm/display/komeda/komeda_color_mgmt.c | 14 ++++++++++++++
    > .../gpu/drm/arm/display/komeda/komeda_color_mgmt.h | 1 +
    > 2 files changed, 15 insertions(+)
    >
    > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_color_mgmt.c b/drivers/gpu/drm/arm/display/komeda/komeda_color_mgmt.c
    > index c180ce70c26c..ad668accbdf4 100644
    > --- a/drivers/gpu/drm/arm/display/komeda/komeda_color_mgmt.c
    > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_color_mgmt.c
    > @@ -117,3 +117,17 @@ void drm_lut_to_fgamma_coeffs(struct drm_property_blob *lut_blob, u32 *coeffs)
    > {
    > drm_lut_to_coeffs(lut_blob, coeffs, sector_tbl, ARRAY_SIZE(sector_tbl));
    > }
    > +
    > +void drm_ctm_to_coeffs(struct drm_property_blob *ctm_blob, u32 *coeffs)
    [nit] Could do with an extra const or two on the drm_property_blob,
    otherwise...
    > +{
    > + struct drm_color_ctm *ctm;
    > + u32 i;
    > +
    > + if (!ctm_blob)
    > + return;
    > +
    > + ctm = ctm_blob->data;
    > +
    > + for (i = 0; i < KOMEDA_N_CTM_COEFFS; i++)
    > + coeffs[i] = drm_color_ctm_s31_32_to_qm_n(ctm->matrix[i], 2, 12);
    > +}
    > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_color_mgmt.h b/drivers/gpu/drm/arm/display/komeda/komeda_color_mgmt.h
    > index 08ab69281648..2f4668466112 100644
    > --- a/drivers/gpu/drm/arm/display/komeda/komeda_color_mgmt.h
    > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_color_mgmt.h
    > @@ -18,6 +18,7 @@
    > #define KOMEDA_N_CTM_COEFFS 9
    >
    > void drm_lut_to_fgamma_coeffs(struct drm_property_blob *lut_blob, u32 *coeffs);
    > +void drm_ctm_to_coeffs(struct drm_property_blob *ctm_blob, u32 *coeffs);
    >
    > const s32 *komeda_select_yuv2rgb_coeffs(u32 color_encoding, u32 color_range);
    >
    >
    ...
    Reviewed-by: Mihail Atanassov <mihail.atanassov@arm.com>

    --
    Mihail



    \
     
     \ /
      Last update: 2019-10-11 10:40    [W:4.151 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site