| Date | Thu, 10 Oct 2019 09:16:48 +0200 | From | Boris Brezillon <> | Subject | Re: [PATCH v2 07/22] mtd: spi-nor: Rework read_cr() |
| |
On Tue, 24 Sep 2019 07:46:15 +0000 <Tudor.Ambarus@microchip.com> wrote:
> From: Tudor Ambarus <tudor.ambarus@microchip.com> > > static int read_cr(struct spi_nor *nor) > becomes > static int spi_nor_read_cr(struct spi_nor *nor, u8 *cr) > > The new function returns 0 on success and -errno otherwise. > We let the callers pass the pointer to the buffer where the > value of the Configuration Register will be written. This way > we avoid the casts between int and u8, which can be confusing. > > Prepend spi_nor_ to the function name, all functions should begin > with that. >
Same as for patch 5, this should be split in several patches
> Vendors are using both the "Configuration Register" and the > "Status Register 2" terminology when referring to the second byte > of the Status Register. Indicate in the description of the function > that we use the SPINOR_OP_RDCR (35h) command to interrogate the
^query
> Configuration Register. >
|