lkml.org 
[lkml]   [2019]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] virt: vbox: fix memory leak in hgcm_call_preprocess_linaddr
From
Date
Hi,

On 30-09-2019 22:42, Navid Emamdoost wrote:
> In hgcm_call_preprocess_linaddr memory is allocated for bounce_buf but
> is not released if copy_form_user fails. In order to prevent memory leak
> in case of failure, the assignment to bounce_buf_ret is moved before the
> error check. This way the allocated bounce_buf will be released by the
> caller.
>
> Fixes: 579db9d45cb4 ("virt: Add vboxguest VMMDEV communication code")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>

Thank you.

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
> drivers/virt/vboxguest/vboxguest_utils.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/virt/vboxguest/vboxguest_utils.c b/drivers/virt/vboxguest/vboxguest_utils.c
> index 75fd140b02ff..43c391626a00 100644
> --- a/drivers/virt/vboxguest/vboxguest_utils.c
> +++ b/drivers/virt/vboxguest/vboxguest_utils.c
> @@ -220,6 +220,8 @@ static int hgcm_call_preprocess_linaddr(
> if (!bounce_buf)
> return -ENOMEM;
>
> + *bounce_buf_ret = bounce_buf;
> +
> if (copy_in) {
> ret = copy_from_user(bounce_buf, (void __user *)buf, len);
> if (ret)
> @@ -228,7 +230,6 @@ static int hgcm_call_preprocess_linaddr(
> memset(bounce_buf, 0, len);
> }
>
> - *bounce_buf_ret = bounce_buf;
> hgcm_call_add_pagelist_size(bounce_buf, len, extra);
> return 0;
> }
>

\
 
 \ /
  Last update: 2019-10-01 08:17    [W:0.039 / U:1.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site