Messages in this thread | | | Date | Tue, 1 Oct 2019 22:10:14 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v22 06/24] x86/sgx: Add SGX microarchitectural data structures |
| |
On Fri, Sep 27, 2019 at 06:27:35PM +0200, Borislav Petkov wrote: > On Tue, Sep 03, 2019 at 05:26:37PM +0300, Jarkko Sakkinen wrote: > > Define the SGX microarchitectural data structures used by various SGX > > opcodes. This is not an exhaustive representation of all SGX data > > structures but only those needed by the kernel. > > > > [1] Intel SDM: 37.6 INTEL® SGX DATA STRUCTURES OVERVIEW > > That footnote is not being referred to. Just make it a sentence.
Sure!
> Btw, you could tell your SDM folks to fix formulations like: > > "The use of EAX is implied implicitly by the ENCLS, ENCLU, and ENCLV > ^^^^^^^^^^^^^^^^^^^ > > instructions.... The use of additional registers does not use ModR/M > encoding and is implied implicitly by the respective leaf function > ^^^^^^^^^^^^^^^^^^^ > > index." > > "implied" alone wasn't enough I guess. :)
I'd guess have make it a double :-)
/Jarkko
| |