Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 9 Jan 2019 19:30:52 +0100 | Subject | Re: [PATCH v2] arm64: dts: meson: Fix mmc cd-gpio polarity |
| |
Hi Ollivier!
On Wed, Jan 9, 2019 at 2:56 PM Loys Ollivier <lollivier@baylibre.com> wrote:
> Commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree") > changed the behavior of "cd-inverted" to follow the device tree bindings > specification. > Lines specifying "cd-inverted" are now "acitve high". > > Fix the SD card for meson by setting the cd-gpio as "active low" according > to the boards specifications. > > Fixes: 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree") > Signed-off-by: Loys Ollivier <lollivier@baylibre.com> > > v2: fix more occurences, also in other meson boards.
This is a good change in itself since it gets rid of some occasions of the dreaded "cd-inverted" property. I think Martin Blumenstingl already sent patches like these though (I might be confused).
But we should keep the old device trees working as well. Can you test if Martins patch: https://marc.info/?l=linux-mmc&m=154637189021211&w=2
Also makes your boards work?
Yours, Linus Walleij
| |