Messages in this thread | | | Date | Wed, 9 Jan 2019 12:33:07 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 7/8] spi: lpspi: Add cs-gpio support |
| |
On Mon, Jan 07, 2019 at 07:47:47AM +0000, Clark Wang wrote: > Add cs-gpio feature for LPSPI. > The cs line will be controlled in fsl_lpspi_transfe_one_msg() function. > > Still support using the mode without cs-gpio. It depends on if attribute > cs-gpio has been configured in dts file.
This is open coding the GPIO - it'd be better to convert to use transfer_one() so you can use the core GPIO handling but that's not really directly relevant to this patch so I'm going to apply, just something it'd be good to work on. [unhandled content-type:application/pgp-signature] | |