Messages in this thread | | | Date | Wed, 9 Jan 2019 09:32:02 +0100 | From | Gerd Hoffmann <> | Subject | Re: [PATCH] qxl: Use struct_size() in kzalloc() |
| |
On Tue, Jan 08, 2019 at 10:21:52AM -0600, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is finding the > size of a structure that has a zero-sized array at the end, along with memory > for some number of elements for that array. For example: > > struct foo { > int stuff; > void *entry[]; > }; > > instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); > > Instead of leaving these open-coded and prone to type mistakes, we can now > use the new struct_size() helper: > > instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); > > This code was detected with the help of Coccinelle.
Patch queued up.
thanks, Gerd
| |