Messages in this thread | | | Date | Wed, 9 Jan 2019 21:36:41 -0500 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR |
| |
On Wed, Jan 09, 2019 at 11:35:52AM +0100, Miguel Ojeda wrote: > On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers <ndesaulniers@google.com> wrote: > > > > Also for more context, see: > > commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against > > dead store elimination") > > By the way, shouldn't that barrier_data() be directly in compiler.h > too, since it is for both gcc & clang? > > > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > > > > + Miguel > > Miguel, would you mind taking this into your compiler-attributes tree? > > Sure, at least we get quickly some linux-next time.
BTW why linux-next? shouldn't this go into 5.0 and stable? It's a bugfix after all.
> Note it would be nice to separate the patch into two (one for the > comments, another for OPTIMIZER_HIDE_VAR), and also possibly another > for barrier_data(). > > Cheers, > Miguel
| |