lkml.org 
[lkml]   [2019]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/3] drivers: platform: goldfish: goldfish_sync: add a driver
On Mon, Jan 07, 2019 at 10:50:39AM -0800, rkir@google.com wrote:
> From: Roman Kiryanov <rkir@google.com>
>
> The Goldfish sync driver is designed to provide a interface
> between the underlying host's sync device and the kernel's
> fence sync framework.
>
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> ---
> Changes in v2:
> - Added a missing include (mod_devicetable.h).
> - Put in one batch with goldfish_address_space.c to avoid merge comflicts.

You have a number of WARN_ON() calls in here that are not needed, please
remove.

Also, why is this driver needed at all? Why can't you use the "normal"
drm sync api interface? Why write a custom ioctl driver just for this
one kernel interface?

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-01-08 13:14    [W:0.040 / U:1.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site