Messages in this thread | | | Date | Mon, 7 Jan 2019 11:48:58 -0700 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] IB/usnic: Use struct_size() in kmalloc() |
| |
On Mon, Jan 07, 2019 at 11:39:54AM -0600, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct foo { > int stuff; > void *entry[]; > }; > > instance = kmalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); > > Instead of leaving these open-coded and prone to type mistakes, we can > now use the new struct_size() helper: > > instance = kmalloc(struct_size(instance, entry, count), GFP_KERNEL); > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/infiniband/hw/usnic/usnic_uiom.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-)
Applied to for-next, thanks
Jason
| |