lkml.org 
[lkml]   [2019]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC net-next 11/15] net: lora: Add IMST WiMOD
    From
    Date
    On 7/1/18 1:08 PM, Andreas Färber wrote:
    > The IMST WiMOD uses a SLIP based binary UART protocol. Two separate
    > firmwares are available. By default it ships with a LoRaWAN firmware.
    > The alternative firmware is a custom P2P addressing mode based on LoRa.
    >
    > Cc: Jon Ortego <Jon.Ortego@imst.de>
    > Signed-off-by: Andreas Färber <afaerber@suse.de>
    > ---
    > drivers/net/lora/Kconfig | 8 +
    > drivers/net/lora/Makefile | 3 +
    > drivers/net/lora/wimod.c | 597 ++++++++++++++++++++++++++++++++++++++++++++++
    > 3 files changed, 608 insertions(+)
    > create mode 100644 drivers/net/lora/wimod.c
    >
    > diff --git a/drivers/net/lora/Kconfig b/drivers/net/lora/Kconfig
    > index 940bd2cbe106..2e05caef8645 100644
    > --- a/drivers/net/lora/Kconfig
    > +++ b/drivers/net/lora/Kconfig
    > @@ -31,6 +31,14 @@ config LORA_SX1276
    > help
    > Semtech SX1272/1276/1278
    >
    > +config LORA_WIMOD
    > + tristate "IMST WiMOD driver"

    scripts/checkpatch.pl throws this warning:
    WARNING: please write a paragraph that describes the config symbol fully

    IMST has multiple products related to "WiMOD":
    * WiMOD iC880A
    * WiMOD module iM871A
    * WSA01-iM880B - WiMOD Shield for Arduino
    * iM880B-L - Long Range Radio Module

    And IMST is not very consistent about what is called "WiMOD". So this
    leaves me clueless concerning what this Kconfig option is about. Please,
    provide a description.

    There are dozens of warnings given by scripts/checkpatch. Please, have a
    look at them.

    Best regards

    Heinrich

    \
     
     \ /
      Last update: 2019-01-06 15:59    [W:2.553 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site