Messages in this thread | | | Subject | Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver | From | Jacek Anaszewski <> | Date | Sat, 5 Jan 2019 14:16:17 +0100 |
| |
On 1/5/19 1:31 PM, Pavel Machek wrote: >>> We will need to solve RGB leds somehow, hopefully this is solved with >>> it. >> >> When? With this attitude we will procrastinate it forever. >> It's been almost 3 years since first HSV patches. >> >> I proposed rough design of LED RGB class interface in [0]. >> If you find it totally flawed, then please spot the problems. >> If not, let's improve it and implement. > > That is fatally flawed, and inferior to the HSV patches, sorry...
Please spot the problems.
> Grab yourself an RGB LED and play with it; you'll see what the > problems are. It is hard to explain colors over email...
Video [0] gives some overview of lp5024 capabilities.
I don't see any problems in exposing separate red,green,blue files and brightness for the devices with hardware support for that.
I want to push things forward and I'm going to ask Dan to give this design a try.
[0] https://www.youtube.com/watch?v=qdt-alh8i6E
-- Best regards, Jacek Anaszewski
| |