lkml.org 
[lkml]   [2019]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] scripts: coccinelle: boolinit: drop warnings on named constants
On Sat, Dec 29, 2018 at 10:14 PM Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>
> Coccinelle doesn't always have access to the values of named
> (#define) constants, and they may likely often be bound to true
> and false values anyway, resulting in false positives. So stop
> warning about them.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Applied to linux-kbuild. Thanks!


> ---
> scripts/coccinelle/misc/boolinit.cocci | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/scripts/coccinelle/misc/boolinit.cocci b/scripts/coccinelle/misc/boolinit.cocci
> index b0584a3..aabb581 100644
> --- a/scripts/coccinelle/misc/boolinit.cocci
> +++ b/scripts/coccinelle/misc/boolinit.cocci
> @@ -136,9 +136,14 @@ position p1;
> @r4 depends on !patch@
> bool b;
> position p2;
> +identifier i;
> constant c != {0,1};
> @@
> +(
> + b = i
> +|
> *b@p2 = c
> +)
>
> @script:python depends on org@
> p << r1.p;
>


--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2019-01-06 02:43    [W:0.030 / U:1.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site