lkml.org 
[lkml]   [2019]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 05/25] char/nvram: Adopt arch_nvram_ops
On Fri, Jan 04, 2019 at 09:08:13AM +1100, Finn Thain wrote:
> On Thu, 3 Jan 2019, Christoph Hellwig wrote:
>
> > > +
> > > +const struct nvram_ops arch_nvram_ops = {
> > > + .read_byte = nvram_read_byte,
> > > + .write_byte = nvram_write_byte,
> > > + .get_size = nvram_get_size,
> > > +};
> > > +EXPORT_SYMBOL(arch_nvram_ops);
> >
> > I think something this internal should always be EXPORT_SYMBOL_GPL.
> >
>
> By "internal" do you mean "not involving interests outside of the Linux
> Foundation"? TBH, I don't know who's affected.

Linux Foundation doesn't matter.

But as far as I can see you export the struct from arch code
for nvram.ko to use them and no one else, which is clearly internal.

\
 
 \ /
  Last update: 2019-01-04 18:57    [W:0.159 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site