Messages in this thread | | | Subject | Re: [PATCH v4 1/3] drivers: amba: Updates to component identification for driver matching. | From | Sai Prakash Ranjan <> | Date | Thu, 31 Jan 2019 16:53:10 +0530 |
| |
On 1/31/2019 5:10 AM, Mike Leach wrote: > The CoreSight specification (ARM IHI 0029E), updates the ID register > requirements for components on an AMBA bus, to cover both traditional > ARM Primecell type devices, and newer CoreSight and other components. > > The Peripheral ID (PID) / Component ID (CID) pair is extended in certain > cases to uniquely identify components. CoreSight components related to > a single function can share Peripheral ID values, and must be further > identified using a Unique Component Identifier (UCI). e.g. the ETM, CTI, > PMU and Debug hardware of the A35 all share the same PID. > > Bits 15:12 of the CID are defined to be the device class. > Class 0xF remains for PrimeCell and legacy components. > Class 0x9 defines the component as CoreSight (CORESIGHT_CID above) > Class 0x0, 0x1, 0xB, 0xE define components that do not have driver support > at present. > Class 0x2-0x8,0xA and 0xD-0xD are presently reserved. > > The specification futher defines which classes of device use the standard > CID/PID pair, and when additional ID registers are required. > > This patch introduces the amba_cs_uci_id structure which will be used in > all coresight drivers for indentification via the private data pointer in > the amba_id structure. > > Existing drivers that currently use the amba_id->data pointer for private > data are updated to use the amba_cs_uci_id->data pointer. Macros and > inline functions are added to simplify this code. >
Thanks Mike, this fixes STM probe with UCI change.
Tested-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |