Messages in this thread | | | Date | Wed, 30 Jan 2019 20:33:48 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 1/4] arm64: dump: no need to check return value of debugfs_create functions |
| |
On Wed, Jan 30, 2019 at 06:21:02PM +0000, Will Deacon wrote: > Hi Greg, > > On Tue, Jan 22, 2019 at 03:41:11PM +0100, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > > > > Cc: Catalin Marinas <catalin.marinas@arm.com> > > Cc: Will Deacon <will.deacon@arm.com> > > Cc: Marc Zyngier <marc.zyngier@arm.com> > > Cc: Peng Donglin <dolinux.peng@gmail.com> > > Cc: <linux-arm-kernel@lists.infradead.org> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > arch/arm64/include/asm/ptdump.h | 9 +++------ > > arch/arm64/mm/dump.c | 4 ++-- > > arch/arm64/mm/ptdump_debugfs.c | 7 ++----- > > 3 files changed, 7 insertions(+), 13 deletions(-) > > Are you taking this via your tree, or would you like us to queue it in > arm64?
What ever is easiest for you is fine with me, I can handle it either way, just let me know.
thanks,
greg k-h
| |