Messages in this thread | | | Subject | Re: [PATCH] x86/events: Mark expected switch fall-throughs | From | "Gustavo A. R. Silva" <> | Date | Tue, 29 Jan 2019 09:58:05 -0600 |
| |
On 1/29/19 9:25 AM, Borislav Petkov wrote: > On Fri, Jan 25, 2019 at 12:49:17PM -0600, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warnings: >> >> In file included from arch/x86/events/intel/core.c:22: >> arch/x86/events/intel/core.c: In function ‘intel_pmu_init’: >> arch/x86/events/intel/../perf_event.h:668:17: warning: this statement may fall through [-Wimplicit-fallthrough=] >> x86_pmu.quirks = &__quirk; \ >> ~~~~~~~~~~~~~~~^~~~~~~~~~ >> arch/x86/events/intel/core.c:4170:3: note: in expansion of macro ‘x86_add_quirk’ >> x86_add_quirk(intel_clovertown_quirk); >> ^~~~~~~~~~~~~ >> arch/x86/events/intel/core.c:4171:2: note: here >> case INTEL_FAM6_CORE2_MEROM_L: >> ^~~~ >> arch/x86/events/intel/lbr.c:929:6: warning: this statement may fall through [-Wimplicit-fallthrough=] >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> arch/x86/events/intel/core.c | 2 ++ >> arch/x86/events/intel/lbr.c | 1 + >> 2 files changed, 3 insertions(+) > > You do know how to use scripts/get_maintainer.pl, right? > > Because I don't see PeterZ on CC. > > Please use that script when preparing patches. >
$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback arch/x86/events/intel/core.c Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) Borislav Petkov <bp@alien8.de> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) "H. Peter Anvin" <hpa@zytor.com> (reviewer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT))
$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback arch/x86/events/intel/lbr.c Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) Borislav Petkov <bp@alien8.de> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) "H. Peter Anvin" <hpa@zytor.com> (reviewer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT))
Does the MAINTAINERS file need an update?
-- Gustavo
| |