Messages in this thread Patch in this message | | | From | Christoph Hellwig <> | Subject | [PATCH 6/8] parisc/dino: use container_of in DINO_DEV | Date | Tue, 29 Jan 2019 19:13:08 +0100 |
| |
Use the type safe container_of macros instead of a blind cast in DINO_DEV, and turn the macro into an inline function.
Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/parisc/dino.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/parisc/dino.c b/drivers/parisc/dino.c index 6f348c75687c..846b59d15999 100644 --- a/drivers/parisc/dino.c +++ b/drivers/parisc/dino.c @@ -154,12 +154,10 @@ struct dino_device #endif }; -/* Looks nice and keeps the compiler happy */ -#define DINO_DEV(d) ({ \ - void *__pdata = d; \ - BUG_ON(!__pdata); \ - (struct dino_device *)__pdata; }) - +static inline struct dino_device *DINO_DEV(struct pci_hba_data *hba) +{ + return container_of(hba, struct dino_device, hba); +} /* * Dino Configuration Space Accessor Functions -- 2.20.1
| |