| Date | Mon, 28 Jan 2019 08:28:25 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH AUTOSEL 4.19 094/258] nfp: add locking around representor changes |
| |
On Mon, 28 Jan 2019 10:56:40 -0500, Sasha Levin wrote: > From: Jakub Kicinski <jakub.kicinski@netronome.com> > > [ Upstream commit 71844fac1ed459024dd2a448d63d5b28b8c87daa ] > > Up until now we never needed to keep a networking locks around > representors accesses, we only accessed them when device was > reconfigured (under nfp pf->lock) or on fast path (under RCU). > Now we want to be able to iterate over all representors during > notifications, so make sure representor assignment is done > under RTNL lock. > > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> > Reviewed-by: John Hurley <john.hurley@netronome.com> > Signed-off-by: David S. Miller <davem@davemloft.net> > Signed-off-by: Sasha Levin <sashal@kernel.org>
Hi Sasha!
There is no need for backporting this unless 51a6588e8c08 ("nfp: add offloads on representors") is also back ported (which is a feature).
|