lkml.org 
[lkml]   [2019]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 01/13] KVM: s390: drop obsolete else path
    On Thu, 24 Jan 2019 13:59:27 +0100
    Michael Mueller <mimu@linux.ibm.com> wrote:

    > The explicit else path specified in set_intercept_indicators_io
    > is not required as the function returns in case the first branch
    > is taken anyway.
    >
    > Signed-off-by: Michael Mueller <mimu@linux.ibm.com>

    Reviewed-by: Halil Pasic <pasic@linux.ibm.com>

    > ---
    > arch/s390/kvm/interrupt.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
    > index fcb55b02990e..19d556512452 100644
    > --- a/arch/s390/kvm/interrupt.c
    > +++ b/arch/s390/kvm/interrupt.c
    > @@ -345,7 +345,7 @@ static void set_intercept_indicators_io(struct kvm_vcpu *vcpu)
    > {
    > if (!(pending_irqs_no_gisa(vcpu) & IRQ_PEND_IO_MASK))
    > return;
    > - else if (psw_ioint_disabled(vcpu))
    > + if (psw_ioint_disabled(vcpu))
    > kvm_s390_set_cpuflags(vcpu, CPUSTAT_IO_INT);
    > else
    > vcpu->arch.sie_block->lctl |= LCTL_CR6;

    \
     
     \ /
      Last update: 2019-01-28 14:58    [W:4.000 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site