Messages in this thread | | | Date | Mon, 28 Jan 2019 05:42:42 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH trivial] kernel.h: Make container_of_safe type safe |
| |
On Thu, Jan 24, 2019 at 08:55:05PM +0000, Jason Gunthorpe wrote: > The final ternary expression is given void * and type * as arguments, so > the resulting type of the macro ends up being void *. > > container_of returns a type which maches the argument, this provides type > safety and allows the expression to be immediately used as the target > type. > > Explicitly cast ERR_CAST() to get the correct type.
I think we should just kill off container_of_safe - it has no user in the tree, is grossly misnamed and not really all that useful to start with.
| |