Messages in this thread | | | Subject | Re: [PATCH 1/8] platform/x86: intel_cht_int33fe: Remove connection for the alt mode mux | From | Hans de Goede <> | Date | Mon, 28 Jan 2019 11:44:29 +0100 |
| |
Hi,
On 28-01-19 10:45, Andy Shevchenko wrote: > On Fri, Jan 25, 2019 at 3:17 PM Heikki Krogerus > <heikki.krogerus@linux.intel.com> wrote: >> >> Driver for fusb302 does not support alternate modes, so the >> connection is not really needed for now. Removing that >> connection description allows us to improve the USB Type-C >> mux API. >> > > Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> > supposed to go via USB tree.
I missed the original posting of this, so let me reply here:
Nack to this change, I've a patch-set in the works to make display-port over type-c work with 2 devices with a fusb302 mux and that needs this connection.
Regards,
Hans
> >> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> >> --- >> drivers/platform/x86/intel_cht_int33fe.c | 11 ++++------- >> 1 file changed, 4 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/platform/x86/intel_cht_int33fe.c b/drivers/platform/x86/intel_cht_int33fe.c >> index 02bc74608cf3..fbd24daa7f8d 100644 >> --- a/drivers/platform/x86/intel_cht_int33fe.c >> +++ b/drivers/platform/x86/intel_cht_int33fe.c >> @@ -32,7 +32,7 @@ struct cht_int33fe_data { >> struct i2c_client *fusb302; >> struct i2c_client *pi3usb30532; >> /* Contain a list-head must be per device */ >> - struct device_connection connections[5]; >> + struct device_connection connections[4]; >> }; >> >> /* >> @@ -178,12 +178,9 @@ static int cht_int33fe_probe(struct platform_device *pdev) >> data->connections[1].endpoint[0] = "port0"; >> data->connections[1].endpoint[1] = "i2c-pi3usb30532"; >> data->connections[1].id = "typec-mux"; >> - data->connections[2].endpoint[0] = "port0"; >> - data->connections[2].endpoint[1] = "i2c-pi3usb30532"; >> - data->connections[2].id = "idff01m01"; >> - data->connections[3].endpoint[0] = "i2c-fusb302"; >> - data->connections[3].endpoint[1] = "intel_xhci_usb_sw-role-switch"; >> - data->connections[3].id = "usb-role-switch"; >> + data->connections[2].endpoint[0] = "i2c-fusb302"; >> + data->connections[2].endpoint[1] = "intel_xhci_usb_sw-role-switch"; >> + data->connections[2].id = "usb-role-switch"; >> >> device_connections_add(data->connections); >> >> -- >> 2.20.1 >> > >
| |