Messages in this thread | | | Subject | Re: Add Ingenic X1000 RTC support. | From | Zhou Yanjie <> | Date | Tue, 29 Jan 2019 11:53:54 +0800 |
| |
OK, thanks for your suggestions. I'll drop this patch.
On 2019年01月29日 04:48, Paul Cercueil wrote: > Hi, > >> Hello, >> >> This seems like a useless renaming to me, can you elaborate a bit more? >> >> I'd also like to have Paul and Lars-Peter comment. > > According to the patchset, the RTC in the X1000 does not behave any > different > than the one in the JZ4780 SoC. Therefore patches 1/2 should be dropped. > In your devicetree bindings, just use the "ingenic,jz4780-rtc" compatible > string instead. The same goes for all the drivers (e.g. the uart one). > > I don't really mind the renaming, maybe replace "Ingenic JZ47xx SoCs" > with > just "Ingenic SoCs" since XBurst is just the name of the CPU inside these > SoCs. > > Regards, > -Paul >
| |