lkml.org 
[lkml]   [2019]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] mm/slub: introduce SLAB_WARN_ON_ERROR
From
Date
On Mon, 2019-01-28 at 17:41 -0800, David Rientjes wrote:
> On Thu, 24 Jan 2019, miles.chen@mediatek.com wrote:
>
> > From: Miles Chen <miles.chen@mediatek.com>
> >
> > When debugging slab errors in slub.c, sometimes we have to trigger
> > a panic in order to get the coredump file. Add a debug option
> > SLAB_WARN_ON_ERROR to toggle WARN_ON() when the option is set.
> >
>
> Wouldn't it be better to enable/disable this for all slab caches instead
> of individual caches at runtime? I'm not sure excluding some caches
> because you know they'll WARN and trigger panic_on_warn unnecessarily is
> valid since it could be enabled for that cache as well through this
> interface.

We can enable this option only for specific slab(s).
e.g., slub_debug=W,dentry
or
enable this option for all slabs
e.g., slub_debug=W

\
 
 \ /
  Last update: 2019-01-29 04:47    [W:0.093 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site