Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 28 Jan 2019 16:43:47 +0100 | Subject | Re: [PATCH v4] kbuild: Add support for DT binding schema checks |
| |
Hi Rob,
On Mon, Jan 28, 2019 at 4:35 PM Rob Herring <robh@kernel.org> wrote: > On Mon, Jan 28, 2019 at 3:43 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Tue, Dec 11, 2018 at 9:24 PM Rob Herring <robh@kernel.org> wrote: > > > This adds the build infrastructure for checking DT binding schema > > > documents and validating dts files using the binding schema. > > > > > > Check DT binding schema documents: > > > make dt_binding_check > > > > > > Build dts files and check using DT binding schema: > > > make dtbs_check > > > > > > Optionally, DT_SCHEMA_FILES can be passed in with a schema file(s) to > > > use for validation. This makes it easier to find and fix errors > > > generated by a specific schema. > > > > > > Currently, the validation targets are separate from a normal build to > > > avoid a hard dependency on the external DT schema project and because > > > there are lots of warnings generated.
> > BTW, what are the CONFIG dependencies for this to work? > > E.g. defconfig on x86_64 fails, even after enabling CONFIG_OF: > > I generally use allmodconfig which enables building all DTs. > > Yes, there's a dependency on CONFIG_DTC which isn't always enabled > with CONFIG_OF. Maybe it should be. The only other solutions I've
Oh, didn't think of CONFIG_DTC.
> thought of are either always build dtc or make the targets conditional > on CONFIG_DTC. The latter would only change the error message.
Making the target conditional may make it more obvious to the user what's going on. Cfr. "make modules_install" giving a nice explanation when CONFIG_MODULES=n.
Thanks.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |