lkml.org 
[lkml]   [2019]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.20 087/304] f2fs: avoid build warn of fall_through
    Date
    From: Jaegeuk Kim <jaegeuk@kernel.org>

    [ Upstream commit f5d5510e7389fa264337fb524346bac9eb93adc8 ]

    After merging the f2fs tree, today's linux-next build
    (x86_64_allmodconfig) produced this warning:

    In file included from fs/f2fs/dir.c:11:
    fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
    fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if (set)
    ^
    fs/f2fs/f2fs.h:2390:2: note: here
    case FI_DATA_EXIST:
    ^~~~

    Exposed by my use of -Wimplicit-fallthrough

    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/f2fs/f2fs.h | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
    index 1e031971a466..ebad864c031c 100644
    --- a/fs/f2fs/f2fs.h
    +++ b/fs/f2fs/f2fs.h
    @@ -2370,6 +2370,7 @@ static inline void __mark_inode_dirty_flag(struct inode *inode,
    case FI_NEW_INODE:
    if (set)
    return;
    + /* fall through */
    case FI_DATA_EXIST:
    case FI_INLINE_DOTS:
    case FI_PIN_FILE:
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-01-28 18:46    [W:4.850 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site