Messages in this thread | | | Subject | Re: [PATCH v4 4/9] cpufreq: imx6q: Use auto-registration of thermal cooling device | From | Daniel Lezcano <> | Date | Mon, 28 Jan 2019 09:34:54 +0100 |
| |
On 28/01/2019 07:41, Amit Kucheria wrote: > Use the CPUFREQ_AUTO_REGISTER_COOLING_DEV flag to allow cpufreq core to > automatically register as a thermal cooling device. > > This allows removal of boiler plate code from the driver. > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> --- > drivers/cpufreq/imx6q-cpufreq.c | 24 ++---------------------- > 1 file changed, 2 insertions(+), 22 deletions(-) > > diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c > index 9fedf627e000..9935df234fa1 100644 > --- a/drivers/cpufreq/imx6q-cpufreq.c > +++ b/drivers/cpufreq/imx6q-cpufreq.c > @@ -9,7 +9,6 @@ > #include <linux/clk.h> > #include <linux/cpu.h> > #include <linux/cpufreq.h> > -#include <linux/cpu_cooling.h> > #include <linux/err.h> > #include <linux/module.h> > #include <linux/nvmem-consumer.h> > @@ -52,7 +51,6 @@ static struct clk_bulk_data clks[] = { > }; > > static struct device *cpu_dev; > -static struct thermal_cooling_device *cdev; > static bool free_opp; > static struct cpufreq_frequency_table *freq_table; > static unsigned int max_freq; > @@ -193,16 +191,6 @@ static int imx6q_set_target(struct cpufreq_policy *policy, unsigned int index) > return 0; > } > > -static void imx6q_cpufreq_ready(struct cpufreq_policy *policy) > -{ > - cdev = of_cpufreq_cooling_register(policy); > - > - if (!cdev) > - dev_err(cpu_dev, > - "running cpufreq without cooling device: %ld\n", > - PTR_ERR(cdev)); > -} > - > static int imx6q_cpufreq_init(struct cpufreq_policy *policy) > { > int ret; > @@ -214,22 +202,14 @@ static int imx6q_cpufreq_init(struct cpufreq_policy *policy) > return ret; > } > > -static int imx6q_cpufreq_exit(struct cpufreq_policy *policy) > -{ > - cpufreq_cooling_unregister(cdev); > - > - return 0; > -} > - > static struct cpufreq_driver imx6q_cpufreq_driver = { > - .flags = CPUFREQ_NEED_INITIAL_FREQ_CHECK, > + .flags = CPUFREQ_NEED_INITIAL_FREQ_CHECK | > + CPUFREQ_AUTO_REGISTER_COOLING_DEV, > .verify = cpufreq_generic_frequency_table_verify, > .target_index = imx6q_set_target, > .get = cpufreq_generic_get, > .init = imx6q_cpufreq_init, > - .exit = imx6q_cpufreq_exit, > .name = "imx6q-cpufreq", > - .ready = imx6q_cpufreq_ready, > .attr = cpufreq_generic_attr, > .suspend = cpufreq_generic_suspend, > }; >
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |