lkml.org 
[lkml]   [2019]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] regulator: mcp16502: Include linux/gpio/consumer.h to fix build error
Date
On 27/01/2019 at 09:51, Axel Lin wrote:
> Fix below build error:
> drivers/regulator/mcp16502.c: In function ‘mcp16502_gpio_set_mode’:
> drivers/regulator/mcp16502.c:135:3: error: implicit declaration of function ‘gpiod_set_value’; did you mean ‘gpio_set_value’? [-Werror=implicit-function-declaration]
> gpiod_set_value(mcp->lpm, 0);
> ^~~~~~~~~~~~~~~
> gpio_set_value
> drivers/regulator/mcp16502.c: In function ‘mcp16502_probe’:
> drivers/regulator/mcp16502.c:486:13: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_gpio_free’? [-Werror=implicit-function-declaration]
> mcp->lpm = devm_gpiod_get(dev, "lpm", GPIOD_OUT_LOW);
> ^~~~~~~~~~~~~~
> devm_gpio_free
> drivers/regulator/mcp16502.c:486:40: error: ‘GPIOD_OUT_LOW’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_LOW’?
> mcp->lpm = devm_gpiod_get(dev, "lpm", GPIOD_OUT_LOW);
> ^~~~~~~~~~~~~
> GPIOF_INIT_LOW
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks Alex!

> ---
> drivers/regulator/mcp16502.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/mcp16502.c b/drivers/regulator/mcp16502.c
> index 3479ae009b0b..0fc4963bd5b0 100644
> --- a/drivers/regulator/mcp16502.c
> +++ b/drivers/regulator/mcp16502.c
> @@ -17,6 +17,7 @@
> #include <linux/regmap.h>
> #include <linux/regulator/driver.h>
> #include <linux/suspend.h>
> +#include <linux/gpio/consumer.h>
>
> #define VDD_LOW_SEL 0x0D
> #define VDD_HIGH_SEL 0x3F
>


--
Nicolas Ferre
\
 
 \ /
  Last update: 2019-01-28 09:20    [W:3.030 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site