lkml.org 
[lkml]   [2019]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 052/107] cpuidle: big.LITTLE: fix refcount leak
    Date
    From: Yangtao Li <tiny.windzz@gmail.com>

    [ Upstream commit 9456823c842f346c74265fcd98d008d87a7eb6f5 ]

    of_find_node_by_path() acquires a reference to the node
    returned by it and that reference needs to be dropped by its caller.
    bl_idle_init() doesn't do that, so fix it.

    Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
    Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/cpuidle/cpuidle-big_little.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
    index db2ede565f1a..b44476a1b7ad 100644
    --- a/drivers/cpuidle/cpuidle-big_little.c
    +++ b/drivers/cpuidle/cpuidle-big_little.c
    @@ -167,6 +167,7 @@ static int __init bl_idle_init(void)
    {
    int ret;
    struct device_node *root = of_find_node_by_path("/");
    + const struct of_device_id *match_id;

    if (!root)
    return -ENODEV;
    @@ -174,7 +175,11 @@ static int __init bl_idle_init(void)
    /*
    * Initialize the driver just for a compliant set of machines
    */
    - if (!of_match_node(compatible_machine_match, root))
    + match_id = of_match_node(compatible_machine_match, root);
    +
    + of_node_put(root);
    +
    + if (!match_id)
    return -ENODEV;

    if (!mcpm_is_available())
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-01-28 17:48    [W:4.031 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site