lkml.org 
[lkml]   [2019]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] eeprom: at25: Use spi_message_init_with_transfers() instead of open coding
On Fri, 18 Jan 2019 15:05:25 +0100
Geert Uytterhoeven <geert+renesas@glider.be> wrote:

> Reduce code duplication in at25_ee_read() by using the
> spi_message_init_with_transfers() helper.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>

> ---
> v2:
> - Add Acked-by.
> ---
> drivers/misc/eeprom/at25.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
> index 2d8e5388e574710d..18a093e14517ab45 100644
> --- a/drivers/misc/eeprom/at25.c
> +++ b/drivers/misc/eeprom/at25.c
> @@ -103,16 +103,15 @@ static int at25_ee_read(void *priv, unsigned int offset,
> *cp++ = offset >> 0;
> }
>
> - spi_message_init(&m);
> memset(t, 0, sizeof(t));
>
> t[0].tx_buf = command;
> t[0].len = at25->addrlen + 1;
> - spi_message_add_tail(&t[0], &m);
>
> t[1].rx_buf = buf;
> t[1].len = count;
> - spi_message_add_tail(&t[1], &m);
> +
> + spi_message_init_with_transfers(&m, t, ARRAY_SIZE(t));
>
> mutex_lock(&at25->lock);
>

\
 
 \ /
  Last update: 2019-01-26 11:07    [W:0.105 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site