lkml.org 
[lkml]   [2019]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED
On Fri, 25 Jan 2019 10:19:54 +0200
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:

> On Thu, Jan 24, 2019 at 9:35 PM Rodrigo Ribeiro <rodrigorsdc@gmail.com> wrote:
> >
> > Remove the checkpatch.pl check:
> >
> > CHECK: 'RESEVERD' may be misspelled - perhaps 'RESERVED'?
>
> Hey,
>
> A bit curios about this one.
> Are you using this chip/driver ?
>
> Thing is: the part is nearing EOL, and it could be an idea to be
> marked for removal (since it's still in staging).
> But if there are users for this driver, it could be left around for a while.

While it might be going away soon, I'm also not that bothered about
the small amount of churn that a tidy up patch like this causes,
and it might not go away ;)

However it is rather odd to have a 'reserved' entry for a register.
can't see that providing any useful information. Normally I'm
happy to have complete register sets as a form of documentation
if the author wants to do it that way. This however seems silly.

Alex, we haven't really gone with marking things as 'going away'
before. I'd suggest we take a guess and remove it if you and the
team an analog don't think it's in use. Happy to get a patch for
that if you want to send one. Of course, Rodrigo could do that
patch to get started if that works for everyone? :)

Jonathan
>
> Thanks
> Alex
>
> >
> > Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@gmail.com>
> > Signed-off-by: Rafael Tsuha <rafael.tsuha@usp.br>
> > ---
> > This macro is not used anywhere. Should we just correct the
> > spelling or remove the macro?
> >
> > drivers/staging/iio/cdc/ad7152.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> > index 25f51db..c9da6d4 100644
> > --- a/drivers/staging/iio/cdc/ad7152.c
> > +++ b/drivers/staging/iio/cdc/ad7152.c
> > @@ -35,7 +35,7 @@
> > #define AD7152_REG_CH2_GAIN_HIGH 12
> > #define AD7152_REG_CH2_SETUP 14
> > #define AD7152_REG_CFG 15
> > -#define AD7152_REG_RESEVERD 16
> > +#define AD7152_REG_RESERVED 16
> > #define AD7152_REG_CAPDAC_POS 17
> > #define AD7152_REG_CAPDAC_NEG 18
> > #define AD7152_REG_CFG2 26
> > --
> > 2.7.4
> >

\
 
 \ /
  Last update: 2019-01-26 19:10    [W:0.388 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site