Messages in this thread | | | Subject | Re: [linux-sunxi] Re: [PATCH v6 14/22] dt-bindings: sun6i-dsi: Add A64 DSI compatible (w/ A31 fallback) | From | Jagan Teki <> | Date | Sat, 26 Jan 2019 21:39:00 +0530 |
| |
On 25/01/19 9:22 PM, Maxime Ripard wrote: > On Fri, Jan 25, 2019 at 01:28:52AM +0530, Jagan Teki wrote: >> The MIPI DSI controller in Allwinner A64 is similar to A33. >> >> But unlike A33, A64 doesn't have DSI_SCLK gating which eventually >> set the mod clock rate for the controller. >> >> So, use the DSI_DPHY gating for the similar purpose of mod clock >> so-that the controller can operate properly. >> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >> Reviewed-by: Rob Herring <robh@kernel.org> >> --- >> Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt >> index 69e233e8fad1..dbda2e567760 100644 >> --- a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt >> +++ b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt >> @@ -12,6 +12,7 @@ The DSI Encoder generates the DSI signal from the TCON's. >> Required properties: >> - compatible: value must be one of: >> * allwinner,sun6i-a31-mipi-dsi >> + * "allwinner,sun50i-a64-mipi-dsi", "allwinner,sun6i-a31-mipi-dsi" > > The other line doesn't have quotes, we should be consistent
You mean to say, remove quotes like this
allwinner,sun50i-a64-mipi-dsi, allwinner,sun6i-a31-mipi-dsi
This make confusion with comma with allwinner vs next compatible string isn't it? (In fact I did follow the similar like TCON in sun4i-drm.txt)
| |